Add request-close command for dialogs #11045
Conversation
domenic
added
addition/proposal
lukewarlow
force-pushed
the
request-close-command
branch
from
155ca45 to
0b2bccb
Compare
|
I believe this is just waiting on implementor interest cc @smaug---- @annevk |
|
@domenic can I take your comments during WhatNOT to be an official signal that Chrome is interested? |
|
Thanks for checking! We should get @mfreed7 or @josepharhar to represent Chromium in that regard instead, as their team would be the one implementing it. |
There was a problem hiding this comment.
LGTM with nit.
Regarding Chromium implementer interest, I see @mfreed7 already approved https://chromium-review.googlesource.com/c/chromium/src/+/6213975, so I think we can say they are interested.
@smaug---- was vaguely positive during WHATNOT but indeed it would be good to give him a chance to affirmatively comment on this specific PR text.
|
Is this ready to go, or given discussions in Slack is WebKit neutral rather than supportive on this? |
|
You can consider WebKit as interested, but I think we should figure out #11092 as part of this if we think it'll impact the wording. Changing the HTML standard is very much a measure-twice-cut-once type of situation. Or to put it another way: it's better that we figure this out than require everyone reading the standard to figure it out. |
See whatwg/html#11045 Bug: 400647849 Change-Id: Iae7f2d431a097f3542fb3695f1746f8b513ca3c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6316649 Reviewed-by: Mason Freed <[email protected]> Commit-Queue: Luke <[email protected]> Cr-Commit-Position: refs/heads/main@{#1428017}
https://bugs.webkit.org/show_bug.cgi?id=288476 Reviewed by NOBODY (OOPS!). Spec PR: whatwg/html#11045 This patch implements the request-close command for dialog, this maps to the requestClose() method. * LayoutTests/TestExpectations: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/the-button-element/command-and-commandfor/on-dialog-behavior-request-close.tentative-expected.txt: Added. * Source/WebCore/dom/Element.h: * Source/WebCore/html/HTMLButtonElement.cpp: (WebCore::HTMLButtonElement::commandType const): * Source/WebCore/html/HTMLDialogElement.cpp: (WebCore::HTMLDialogElement::isValidCommandType): (WebCore::HTMLDialogElement::handleCommandInternal):
This new command maps to the dialog's requestClose function. - Rename enable close watcher for requestClose() - Add note to enable close watcher for request close
lukewarlow
force-pushed
the
request-close-command
branch
from
82c7bd0 to
3ffc0eb
Compare
|
Apologies for squashing existing commits but it was a pain to rebase otherwise. |
https://bugs.webkit.org/show_bug.cgi?id=288476 Reviewed by NOBODY (OOPS!). Spec PR: whatwg/html#11045 This patch implements the request-close command for dialog, this maps to the requestClose() method. * LayoutTests/TestExpectations: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/the-button-element/command-and-commandfor/on-dialog-behavior-request-close.tentative-expected.txt: Added. * Source/WebCore/dom/Element.h: * Source/WebCore/html/HTMLButtonElement.cpp: (WebCore::HTMLButtonElement::commandType const): * Source/WebCore/html/HTMLDialogElement.cpp: (WebCore::HTMLDialogElement::isValidCommandType): (WebCore::HTMLDialogElement::handleCommandInternal):
Add request-close command for dialogs
This new command maps to the dialog's requestClose function.
(See WHATWG Working Mode: Changes for more details.)
/form-elements.html ( diff )
/indices.html ( diff )
/interactive-elements.html ( diff )